Fix bug when filtering s3 locations #531
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pattern is evaluated against the entire bucket. This doesn't
mattern for suffix searches, but for a prefix search, you'd have to
include the bucket name. This is inconsistent with filtering local
files. Now they're both consistent. Given:
This will filter any full path that startsw with foo. So locally:
And on s3, we now have the same results:
I also added debug logs to help customers troubleshoot why their
filters aren't working the way they expect. For example: